Discussion:
[uClinux-dev] [PATCH 9/9] m68knommu: use ColdFire DMA timer module on devices that have it
Steven King
2014-05-28 15:59:20 UTC
Permalink
From: Greg Ungerer <gerg at uclinux.org>
The DMA timer hardware module is present in all of the 520x, 527x, 528x,
53xx and 5441x families of ColdFire SoC. Use it as clock source on those
parts to give a more accurate clock.
Signed-off-by: Greg Ungerer <gerg at uclinux.org>
---
arch/m68k/platform/coldfire/Makefile | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/m68k/platform/coldfire/Makefile
b/arch/m68k/platform/coldfire/Makefile index 0818f77..cdd0b03 100644
--- a/arch/m68k/platform/coldfire/Makefile
+++ b/arch/m68k/platform/coldfire/Makefile
@@ -17,18 +17,18 @@ asflags-$(CONFIG_FULLDEBUG) :=
-DDEBUGGER_COMPATIBLE_CACHE=1 obj-$(CONFIG_COLDFIRE) += cache.o clk.o
device.o dma.o entry.o vectors.o obj-$(CONFIG_M5206) += m5206.o timers.o
intc.o reset.o
obj-$(CONFIG_M5206e) += m5206.o timers.o intc.o reset.o
-obj-$(CONFIG_M520x) += m520x.o pit.o intc-simr.o reset.o
+obj-$(CONFIG_M520x) += m520x.o pit.o dma_timer.o intc-simr.o reset.o
obj-$(CONFIG_M523x) += m523x.o pit.o dma_timer.o intc-2.o reset.o
obj-$(CONFIG_M5249) += m5249.o timers.o intc.o intc-5249.o reset.o
obj-$(CONFIG_M525x) += m525x.o timers.o intc.o intc-525x.o reset.o
-obj-$(CONFIG_M527x) += m527x.o pit.o intc-2.o reset.o
+obj-$(CONFIG_M527x) += m527x.o pit.o dma_timer.o intc-2.o reset.o
obj-$(CONFIG_M5272) += m5272.o intc-5272.o timers.o
-obj-$(CONFIG_M528x) += m528x.o pit.o intc-2.o reset.o
+obj-$(CONFIG_M528x) += m528x.o pit.o dma_timer.o intc-2.o reset.o
obj-$(CONFIG_M5307) += m5307.o timers.o intc.o reset.o
-obj-$(CONFIG_M53xx) += m53xx.o pit.o intc-simr.o reset.o
+obj-$(CONFIG_M53xx) += m53xx.o pit.o dma_timer.o intc-simr.o reset.o
obj-$(CONFIG_M5407) += m5407.o timers.o intc.o reset.o
obj-$(CONFIG_M54xx) += m54xx.o sltimers.o intc-2.o
-obj-$(CONFIG_M5441x) += m5441x.o pit.o intc-simr.o reset.o
+obj-$(CONFIG_M5441x) += m5441x.o pit.o dma_timer.o intc-simr.o reset.o
obj-$(CONFIG_NETtel) += nettel.o
obj-$(CONFIG_CLEOPATRA) += nettel.o
Hi Greg,

I couldn't get this part to apply. What tree are you using?
Greg Ungerer
2014-05-28 23:46:54 UTC
Permalink
Hi Steven,
Post by Steven King
From: Greg Ungerer <gerg at uclinux.org>
The DMA timer hardware module is present in all of the 520x, 527x, 528x,
53xx and 5441x families of ColdFire SoC. Use it as clock source on those
parts to give a more accurate clock.
Signed-off-by: Greg Ungerer <gerg at uclinux.org>
---
arch/m68k/platform/coldfire/Makefile | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/m68k/platform/coldfire/Makefile
b/arch/m68k/platform/coldfire/Makefile index 0818f77..cdd0b03 100644
--- a/arch/m68k/platform/coldfire/Makefile
+++ b/arch/m68k/platform/coldfire/Makefile
@@ -17,18 +17,18 @@ asflags-$(CONFIG_FULLDEBUG) :=
-DDEBUGGER_COMPATIBLE_CACHE=1 obj-$(CONFIG_COLDFIRE) += cache.o clk.o
device.o dma.o entry.o vectors.o obj-$(CONFIG_M5206) += m5206.o timers.o
intc.o reset.o
obj-$(CONFIG_M5206e) += m5206.o timers.o intc.o reset.o
-obj-$(CONFIG_M520x) += m520x.o pit.o intc-simr.o reset.o
+obj-$(CONFIG_M520x) += m520x.o pit.o dma_timer.o intc-simr.o reset.o
obj-$(CONFIG_M523x) += m523x.o pit.o dma_timer.o intc-2.o reset.o
obj-$(CONFIG_M5249) += m5249.o timers.o intc.o intc-5249.o reset.o
obj-$(CONFIG_M525x) += m525x.o timers.o intc.o intc-525x.o reset.o
-obj-$(CONFIG_M527x) += m527x.o pit.o intc-2.o reset.o
+obj-$(CONFIG_M527x) += m527x.o pit.o dma_timer.o intc-2.o reset.o
obj-$(CONFIG_M5272) += m5272.o intc-5272.o timers.o
-obj-$(CONFIG_M528x) += m528x.o pit.o intc-2.o reset.o
+obj-$(CONFIG_M528x) += m528x.o pit.o dma_timer.o intc-2.o reset.o
obj-$(CONFIG_M5307) += m5307.o timers.o intc.o reset.o
-obj-$(CONFIG_M53xx) += m53xx.o pit.o intc-simr.o reset.o
+obj-$(CONFIG_M53xx) += m53xx.o pit.o dma_timer.o intc-simr.o reset.o
obj-$(CONFIG_M5407) += m5407.o timers.o intc.o reset.o
obj-$(CONFIG_M54xx) += m54xx.o sltimers.o intc-2.o
-obj-$(CONFIG_M5441x) += m5441x.o pit.o intc-simr.o reset.o
+obj-$(CONFIG_M5441x) += m5441x.o pit.o dma_timer.o intc-simr.o reset.o
obj-$(CONFIG_NETtel) += nettel.o
obj-$(CONFIG_CLEOPATRA) += nettel.o
Hi Greg,
I couldn't get this part to apply. What tree are you using?
This was against linux-3.15-rc4

Regards
Greg
Steven King
2014-05-29 23:22:11 UTC
Permalink
From: Greg Ungerer <gerg at uclinux.org>
Most of the modern ColdFire family members contain the DMA timer hardware
module. Build the support code for it and use it on those that do. We can
use it as an accurate time source.
I don't have test platforms based on all of these ColdFire types, it would
be really helpful if anyone that has any of these can test these changes.
It build tests fine on all these types, and it works on 520x and 527x
based platforms.
These changes are (neccessarily) on top of my recent patch series titled
"clean up timer code on the ColdFire 53xx".
Signed-off-by: Greg Ungerer <gerg at uclinux.org>
---
arch/m68k/include/asm/m520xsim.h | 8 ++++++++
arch/m68k/include/asm/m523xsim.h | 8 ++++++++
arch/m68k/include/asm/m527xsim.h | 8 ++++++++
arch/m68k/include/asm/m528xsim.h | 8 ++++++++
arch/m68k/include/asm/m53xxsim.h | 10 +++++-----
arch/m68k/include/asm/m5441xsim.h | 8 ++++++++
arch/m68k/platform/coldfire/Makefile | 10 +++++-----
arch/m68k/platform/coldfire/dma_timer.c | 24 +++++++++++++-----------
8 files changed, 63 insertions(+), 21 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Greg,

I was able to to test this on 528x and 5441x and didnt have problems, so you
can add my Acked-by if you want.
Greg Ungerer
2014-05-30 00:51:34 UTC
Permalink
Hi Steven,
Post by Steven King
From: Greg Ungerer <gerg at uclinux.org>
Most of the modern ColdFire family members contain the DMA timer hardware
module. Build the support code for it and use it on those that do. We can
use it as an accurate time source.
I don't have test platforms based on all of these ColdFire types, it would
be really helpful if anyone that has any of these can test these changes.
It build tests fine on all these types, and it works on 520x and 527x
based platforms.
These changes are (neccessarily) on top of my recent patch series titled
"clean up timer code on the ColdFire 53xx".
Signed-off-by: Greg Ungerer <gerg at uclinux.org>
---
arch/m68k/include/asm/m520xsim.h | 8 ++++++++
arch/m68k/include/asm/m523xsim.h | 8 ++++++++
arch/m68k/include/asm/m527xsim.h | 8 ++++++++
arch/m68k/include/asm/m528xsim.h | 8 ++++++++
arch/m68k/include/asm/m53xxsim.h | 10 +++++-----
arch/m68k/include/asm/m5441xsim.h | 8 ++++++++
arch/m68k/platform/coldfire/Makefile | 10 +++++-----
arch/m68k/platform/coldfire/dma_timer.c | 24 +++++++++++++-----------
8 files changed, 63 insertions(+), 21 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Greg,
I was able to to test this on 528x and 5441x and didnt have problems, so you
can add my Acked-by if you want.
Great, thanks for testing. I will add your acked-by.

The most significant change is for the 532x and 537x, but
I don't have either of those to test with.

Regards
Greg

Loading...