[uClinux-dev] [PATCH 2/5] net: fec: adopt pinctrl API

[Steven King]

Cc: David S. Miller <davem at davemloft.net>
Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
---
drivers/net/ethernet/freescale/fec.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)

As the fec driver is also used by m68k/coldfire, perhaps a CC to the
uclinux-dev at uclinux.org would be apropos.

+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto failed_pin;
+ }

What happens here if pinmux support isnt implemented yet as is the case for
m68k/coldfire?

[Shawn Guo]

Post by Steven King

+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl)) {
+ ret = PTR_ERR(pinctrl);
+ goto failed_pin;
+ }

What happens here if pinmux support isnt implemented yet as is the case for
m68k/coldfire?

There are a set of stub functions defined for !CONFIG_PINCTRL
in include/linux/pinctrl/consumer.h to ensure the pinctrl calls
succeed for those cases.