[uClinux-dev] Initial Timer on m5329 not running

Discussion:

Christian Gieseler

2013-03-26 06:54:30 UTC

Hi List,

Coldfire 5329 seems not be used with latest kernels. The Main Timer is not
running, so the scheduler won?t behave like expected.

To change this the following change has to be done in m532x.c arch setup.
There is probably more to be fixed.

diff git a/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
b/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c

--- a/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c

+++ b/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c

@@ 120,6 +120,8 @@ static struct clk * const enable_clks[] __initconst = {

&__clk_0_25, /* mcfuart.1 */

&__clk_0_26, /* mcfuart.2 */

+ &__clk_0_28, /* mcftmr.0 */

+ &__clk_0_29, /* mcftmr.1 */

&__clk_0_32, /* mcfpit.0 */

&__clk_0_33, /* mcfpit.1 */

&__clk_0_37, /* mcfeport.0 */

@@ 135,8 +137,6 @@ static struct clk * const disable_clks[] __initconst = {

&__clk_0_17, /* edma */

&__clk_0_22, /* mcfi2c.0 */

&__clk_0_23, /* mcfqspi.0 */

- &__clk_0_28, /* mcftmr.0 */

- &__clk_0_29, /* mcftmr.1 */

&__clk_0_30, /* mcftmr.2 */

&__clk_0_31, /* mcftmr.3 */

&__clk_0_34, /* mcfpit.2 */

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.uclinux.org/pipermail/uclinux-dev/attachments/20130326/91065952/attachment.html>

Greg Ungerer

2013-04-02 06:27:27 UTC

Permalink

Hi Christian,

Coldfire 5329 seems not be used with latest kernels. The Main Timer is not running, so the scheduler won?t behave like expected.
To change this the following change has to be done in m532x.c arch setup. There is probably more to be fixed.

Please do post any follow up patches you need to make it work.
Bonus points if you create them in readily git appliable format
(as per Documentation/SubmittingPatches).

diff git a/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c b/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
--- a/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
+++ b/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
@@ 120,6 +120,8 @@ static struct clk * const enable_clks[] __initconst = {
&__clk_0_25, /* mcfuart.1 */
&__clk_0_26, /* mcfuart.2 */
+ &__clk_0_28, /* mcftmr.0 */
+ &__clk_0_29, /* mcftmr.1 */

Is this patch reversed?
This is the order they are in the latest kernels.

Regards
Greg

&__clk_0_32, /* mcfpit.0 */
&__clk_0_33, /* mcfpit.1 */
&__clk_0_37, /* mcfeport.0 */
@@ 135,8 +137,6 @@ static struct clk * const disable_clks[] __initconst = {
&__clk_0_17, /* edma */
&__clk_0_22, /* mcfi2c.0 */
&__clk_0_23, /* mcfqspi.0 */
- &__clk_0_28, /* mcftmr.0 */
- &__clk_0_29, /* mcftmr.1 */
&__clk_0_30, /* mcftmr.2 */
&__clk_0_31, /* mcftmr.3 */
&__clk_0_34, /* mcfpit.2 */
_______________________________________________
uClinux-dev mailing list
uClinux-dev at uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev at uclinux.org
http://mailman.uclinux.org/mailman/options/uclinux-dev

Christian Gieseler

2013-04-16 09:03:29 UTC

Permalink

Hi Greg,

-----Original Message-----
From: Greg Ungerer [mailto:gregungerer at westnet.com.au]
Sent: Tuesday, April 02, 2013 8:27 AM
To: uClinux development list
Cc: Christian Gieseler
Subject: Re: [uClinux-dev] Initial Timer on m5329 not running
Hi Christian,

Post by Christian Gieseler
Coldfire 5329 seems not be used with latest kernels. The Main Timer is not

running, so the scheduler won?t behave like expected.

Post by Christian Gieseler
To change this the following change has to be done in m532x.c arch setup.

There is probably more to be fixed.
Please do post any follow up patches you need to make it work.
Bonus points if you create them in readily git appliable format (as
per Documentation/SubmittingPatches).

Ok.

Post by Christian Gieseler
diff git a/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
b/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
--- a/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
+++ b/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
@@ 120,6 +120,8 @@ static struct clk * const enable_clks[]
__initconst = {
&__clk_0_25, /* mcfuart.1 */
&__clk_0_26, /* mcfuart.2 */
+ &__clk_0_28, /* mcftmr.0 */
+ &__clk_0_29, /* mcftmr.1 */

Is this patch reversed?

What do you mean with reversed? If I have a look at
http://lxr.linux.no/#linux+v3.8.7/arch/m68k/platform/coldfire/m532x.c they
are disabled.

Regards
Christian

Greg Ungerer

2013-04-16 14:08:50 UTC

Permalink

Hi Christian,

Post by Christian Gieseler

-----Original Message-----
From: Greg Ungerer [mailto:gregungerer at westnet.com.au]
Sent: Tuesday, April 02, 2013 8:27 AM

Post by Christian Gieseler
diff git a/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
b/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
--- a/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
+++ b/Linux3.6.11/arch/m68k/platform/coldfire/m532x.c
@@ 120,6 +120,8 @@ static struct clk * const enable_clks[] __initconst = {
&__clk_0_25, /* mcfuart.1 */
&__clk_0_26, /* mcfuart.2 */
+ &__clk_0_28, /* mcftmr.0 */
+ &__clk_0_29, /* mcftmr.1 */

Is this patch reversed?

What do you mean with reversed? If I have a look at
http://lxr.linux.no/#linux+v3.8.7/arch/m68k/platform/coldfire/m532x.c

In that file:

&__clk_0_25, /* mcfuart.1 */
&__clk_0_26, /* mcfuart.2 */
&__clk_0_28, /* mcftmr.0 */
&__clk_0_29, /* mcftmr.1 */

Yet your patch above is adding those same mcftimer lines.
So I suspect you diffed the files in the wrong order when you generated
the patch (that is you did "diff <new-file> <old-file>" instead of the
other way around).

Post by Christian Gieseler
they
are disabled.

I don't follow. Disabled?

Regards
Greg

Christian Gieseler

2013-04-16 14:35:17 UTC

Permalink

Hi Greg,

-----Original Message-----
From: Greg Ungerer [mailto:gregungerer at westnet.com.au]
Sent: Tuesday, April 16, 2013 4:09 PM
To: Christian Gieseler
Cc: 'uClinux development list'
Subject: Re: [uClinux-dev] Initial Timer on m5329 not running
Hi Christian,

Post by Christian Gieseler

-----Original Message-----
From: Greg Ungerer [mailto:gregungerer at westnet.com.au]
Sent: Tuesday, April 02, 2013 8:27 AM On 26/03/13 16:54, Christian

Is this patch reversed?

What do you mean with reversed? If I have a look at
http://lxr.linux.no/#linux+v3.8.7/arch/m68k/platform/coldfire/m532x.c

&__clk_0_25, /* mcfuart.1 */
&__clk_0_26, /* mcfuart.2 */
&__clk_0_28, /* mcftmr.0 */
&__clk_0_29, /* mcftmr.1 */
Yet your patch above is adding those same mcftimer lines.
So I suspect you diffed the files in the wrong order when you generated

the

patch (that is you did "diff <new-file> <old-file>" instead of the other

way

around).

Post by Christian Gieseler
they
are disabled.

I don't follow. Disabled?

By disabled i ment that they are liste in disable_clks[] section in the
current mainline version. The Patch adds them to the enable_clks[] section.

Regards
Christian